Skip to content

OAuth2Login DSL should support post-processing AuthenticationProvider implementations #17176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OAuth2Login DSL should support post-processing AuthenticationProvider implementations #17176

wants to merge 2 commits into from

Conversation

fkowal
Copy link

@fkowal fkowal commented May 27, 2025

fix 6.4 -> 6.5 class cast issue / relax type constraint

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 27, 2025
@fkowal fkowal mentioned this pull request May 27, 2025
Closed
@jzheaux
Copy link
Contributor

jzheaux commented Jun 10, 2025

Hi, @fkowal, thanks for the quick fix! Will you please add a test to OAuth2LoginConfigurerTests that would fail before your fix and now it passes?

@jzheaux jzheaux added type: bug A general bug in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 10, 2025
@fkowal
Copy link
Author

fkowal commented Jun 11, 2025

@jzheaux test added

@jzheaux jzheaux self-assigned this Jun 17, 2025
@jzheaux jzheaux changed the title fix: #17175 relax type constraint (6.4 -> 6.5) compatible OAuth2Login DSL should support post-processing AuthenticationProvider implementations Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fkowal @jzheaux @spring-projects-issues